diff options
| author | Thomas Hellstrom <thellstrom@vmware.com> | 2009-03-02 11:10:56 +0100 |
|---|---|---|
| committer | Dave Airlie <airlied@linux.ie> | 2009-03-03 00:50:20 +0100 |
| commit | fda714c29cdf360464059044b221450decb4b913 (patch) | |
| tree | dc985f3c861d9490a1b5ffe82583497b6fe64236 /drivers/gpu/drm/drm_stub.c | |
| parent | drm: Wake up all lock waiters when the master disappears. (diff) | |
| download | linux-fda714c29cdf360464059044b221450decb4b913.tar.xz linux-fda714c29cdf360464059044b221450decb4b913.zip | |
drm: Avoid client deadlocks when the master disappears.
This is done by
1) Wake up lock waiters when we close the master file descriptor.
Not when the master structure is removed, since the latter
requires the waiters themselves to release the refcount on the
master structure -> Deadlock.
2) Send a SIGTERM to all clients waiting for the lock.
Normally these clients will get a SIGPIPE when the X server dies,
but clients may also spin trying to grab the DRM lock, without
getting any sort of notification.
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Dave Airlie <airlied@linux.ie>
Diffstat (limited to 'drivers/gpu/drm/drm_stub.c')
| -rw-r--r-- | drivers/gpu/drm/drm_stub.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 7b251dd70811..096e2a37446d 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -146,14 +146,6 @@ static void drm_master_destroy(struct kref *kref) drm_ht_remove(&master->magiclist); - if (master->lock.hw_lock) { - if (dev->sigdata.lock == master->lock.hw_lock) - dev->sigdata.lock = NULL; - master->lock.hw_lock = NULL; - master->lock.file_priv = NULL; - wake_up_interruptible_all(&master->lock.lock_queue); - } - drm_free(master, sizeof(*master), DRM_MEM_DRIVER); } |