diff options
| author | Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> | 2024-01-19 20:08:40 +0100 |
|---|---|---|
| committer | Heiko Stuebner <heiko@sntech.de> | 2024-02-13 20:33:39 +0100 |
| commit | b6ddaa63f728d26c12048aed76be99c24f435c41 (patch) | |
| tree | 726ab524ce9b567d74c2e4c7bc20cf8f415e3f98 /drivers/gpu/drm/rockchip | |
| parent | drm/crtc: fix uninitialized variable use even harder (diff) | |
| download | linux-b6ddaa63f728d26c12048aed76be99c24f435c41.tar.xz linux-b6ddaa63f728d26c12048aed76be99c24f435c41.zip | |
drm/rockchip: vop2: add a missing unlock in vop2_crtc_atomic_enable()
Unlock before returning on the error path.
Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20240119190841.1619443-1-harshit.m.mogalapalli@oracle.com
Diffstat (limited to 'drivers/gpu/drm/rockchip')
| -rw-r--r-- | drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 85b3b4871a1d..fdd768bbd487 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1985,8 +1985,10 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc, clock = vop2_set_intf_mux(vp, rkencoder->crtc_endpoint_id, polflags); } - if (!clock) + if (!clock) { + vop2_unlock(vop2); return; + } if (vcstate->output_mode == ROCKCHIP_OUT_MODE_AAAA && !(vp_data->feature & VOP2_VP_FEATURE_OUTPUT_10BIT)) |