diff options
| author | Dave Airlie <airlied@redhat.com> | 2011-12-19 12:15:29 +0100 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2012-02-16 19:31:07 +0100 |
| commit | 466e69b8b03b8c1987367912782bc12988ad8794 (patch) | |
| tree | 60ac84ef32b7590618bc81b0b52a5ba14a49bf45 /drivers/gpu/drm/sis | |
| parent | drm/radeon/evergreen: make texdw[] array larger (diff) | |
| download | linux-466e69b8b03b8c1987367912782bc12988ad8794.tar.xz linux-466e69b8b03b8c1987367912782bc12988ad8794.zip | |
drm: move pci bus master enable into driver.
The current enabling of bus mastering in the drm midlayer allows a large
race condition under kexec. When a kexec'ed kernel re-enables bus mastering
for the GPU, previously setup dma blocks may cause writes to random pieces
of memory. On radeon the writeback mechanism can cause these sorts of issues.
This patch doesn't fix the problem, but it moves the bus master enable under
the individual drivers control so they can move enabling it until later in
their load cycle and close the race.
Fix for radeon kms driver will be in a follow-up patch.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/sis')
| -rw-r--r-- | drivers/gpu/drm/sis/sis_drv.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/sis/sis_drv.c b/drivers/gpu/drm/sis/sis_drv.c index 573220cc5269..30d98d14b5c5 100644 --- a/drivers/gpu/drm/sis/sis_drv.c +++ b/drivers/gpu/drm/sis/sis_drv.c @@ -41,6 +41,8 @@ static int sis_driver_load(struct drm_device *dev, unsigned long chipset) { drm_sis_private_t *dev_priv; + pci_set_master(dev->pdev); + dev_priv = kzalloc(sizeof(drm_sis_private_t), GFP_KERNEL); if (dev_priv == NULL) return -ENOMEM; |