diff options
| author | Qinglang Miao <miaoqinglang@huawei.com> | 2020-12-01 13:56:31 +0100 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2021-01-15 17:24:51 +0100 |
| commit | dcdfe2712b68f1e9dbf4f1a96ad59b80e5cc0ef7 (patch) | |
| tree | e0d0adf29d399170db19f54d8145169fdf83fb29 /drivers/gpu/drm/tegra/sor.c | |
| parent | drm/tegra: gr2d: Add compatible for Tegra114 (diff) | |
| download | linux-dcdfe2712b68f1e9dbf4f1a96ad59b80e5cc0ef7.tar.xz linux-dcdfe2712b68f1e9dbf4f1a96ad59b80e5cc0ef7.zip | |
drm/tegra: Fix reference leak when pm_runtime_get_sync() fails
The PM reference count is not expected to be incremented on return in
these Tegra functions.
However, pm_runtime_get_sync() will increment the PM reference count
even on failure. Forgetting to put the reference again will result in
a leak.
Replace it with pm_runtime_resume_and_get() to keep the usage counter
balanced.
Fixes: fd67e9c6ed5a ("drm/tegra: Do not implement runtime PM")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers/gpu/drm/tegra/sor.c')
| -rw-r--r-- | drivers/gpu/drm/tegra/sor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index cc2aa2308a51..f02a035dda45 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3218,7 +3218,7 @@ static int tegra_sor_runtime_resume(struct host1x_client *client) struct device *dev = client->dev; int err; - err = pm_runtime_get_sync(dev); + err = pm_runtime_resume_and_get(dev); if (err < 0) { dev_err(dev, "failed to get runtime PM: %d\n", err); return err; |