summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2009-03-27 11:34:28 +0100
committerDave Airlie <airlied@redhat.com>2009-03-29 10:31:47 +0200
commitdba5ed0cd12d8db5c0d2e1c869c2a50c5bcf6743 (patch)
tree2f3eae8165b595270c77e7c591701d86c4e3aeac /drivers/gpu/drm
parentdrm: reorder struct drm_ioctl_desc to save space on 64 bit builds (diff)
downloadlinux-dba5ed0cd12d8db5c0d2e1c869c2a50c5bcf6743.tar.xz
linux-dba5ed0cd12d8db5c0d2e1c869c2a50c5bcf6743.zip
drm: drm_fops.c unlock missing on error path
drm_open_helper() from drm_fops.c had a missing mutex_unlock in a error path. This was caught by smatch (http://repo.or.cz/w/smatch.git/). Compile tested. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm')
-rw-r--r--drivers/gpu/drm/drm_fops.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/drm_fops.c b/drivers/gpu/drm/drm_fops.c
index e13cb62bbaee..09a3571c9908 100644
--- a/drivers/gpu/drm/drm_fops.c
+++ b/drivers/gpu/drm/drm_fops.c
@@ -274,6 +274,7 @@ static int drm_open_helper(struct inode *inode, struct file *filp,
/* create a new master */
priv->minor->master = drm_master_create(priv->minor);
if (!priv->minor->master) {
+ mutex_unlock(&dev->struct_mutex);
ret = -ENOMEM;
goto out_free;
}