diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-11-26 08:33:14 +0100 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2023-04-04 14:24:28 +0200 |
| commit | 8466ff24a37a9a18fb935e90dda64f049131ae28 (patch) | |
| tree | 05b28eb963492bfffb43164ebef21105cd10ed33 /drivers/gpu/host1x | |
| parent | gpu: host1x: mipi: Use devm_platform_get_and_ioremap_resource() (diff) | |
| download | linux-8466ff24a37a9a18fb935e90dda64f049131ae28.tar.xz linux-8466ff24a37a9a18fb935e90dda64f049131ae28.zip | |
gpu: host1x: Fix potential double free if IOMMU is disabled
If context device has no IOMMU, the 'cdl->devs' is freed in
error path, but host1x_memory_context_list_init() doesn't
return an error code, so the module can be loaded successfully,
when it's unloading, the host1x_memory_context_list_free() is
called in host1x_remove(), it will cause double free. Set the
'cdl->devs' to NULL after freeing it to avoid double free.
Fixes: 8aa5bcb61612 ("gpu: host1x: Add context device management code")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers/gpu/host1x')
| -rw-r--r-- | drivers/gpu/host1x/context.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/host1x/context.c b/drivers/gpu/host1x/context.c index 8beedcf080ab..5ec18315ff9f 100644 --- a/drivers/gpu/host1x/context.c +++ b/drivers/gpu/host1x/context.c @@ -83,6 +83,7 @@ del_devices: device_del(&cdl->devs[i].dev); kfree(cdl->devs); + cdl->devs = NULL; cdl->len = 0; return err; |