diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2013-05-20 19:32:06 +0200 |
|---|---|---|
| committer | Inki Dae <inki.dae@samsung.com> | 2013-05-22 04:45:51 +0200 |
| commit | 4c1d8def9d5bbd642782893ccd849963f1811ae6 (patch) | |
| tree | b7a39bf8f8b0b511a0a3f2180554d1501b9bf193 /drivers/gpu | |
| parent | drm/exynos: exynos_drm_ipp: Fix incorrect usage of IS_ERR_OR_NULL (diff) | |
| download | linux-4c1d8def9d5bbd642782893ccd849963f1811ae6.tar.xz linux-4c1d8def9d5bbd642782893ccd849963f1811ae6.zip | |
drm/exynos: exynos_hdmi: Pass correct pointer to free_irq()
free_irq() expects the same pointer that was passed to request_threaded_irq(),
otherwise the IRQ is not freed.
The issue was found using the following coccinelle script:
<smpl>
@r1@
type T;
T devid;
@@
request_threaded_irq(..., devid)
@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)
@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/exynos/exynos_hdmi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index bbfc3840080c..7e99853f1e18 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -2082,7 +2082,7 @@ static int hdmi_remove(struct platform_device *pdev) pm_runtime_disable(dev); - free_irq(hdata->irq, hdata); + free_irq(hdata->irq, ctx); /* hdmiphy i2c driver */ |