diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2009-06-06 10:45:58 +0200 |
|---|---|---|
| committer | Eric Anholt <eric@anholt.net> | 2009-06-09 22:54:05 +0200 |
| commit | 5f26a2c7ad6eba97141e8372f3def282f934b169 (patch) | |
| tree | 355040e2e6eb308afc3b93e39f3b052b63c4b7bc /drivers/gpu | |
| parent | drm/i915: Sanity check execbuffer arguments before touching state. (diff) | |
| download | linux-5f26a2c7ad6eba97141e8372f3def282f934b169.tar.xz linux-5f26a2c7ad6eba97141e8372f3def282f934b169.zip | |
drm/i915: OR in the COMMAND read domain for the batch buffer.
The batch buffer may be shared with another read buffer, so we should not
ignore any previously set domains, but just or in the command domain (and
check that the buffer is not writable).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Eric Anholt <eric@anholt.net>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_gem.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index ac22668b239a..2d705e8a297e 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -3369,8 +3369,12 @@ i915_gem_execbuffer(struct drm_device *dev, void *data, /* Set the pending read domains for the batch buffer to COMMAND */ batch_obj = object_list[args->buffer_count-1]; - batch_obj->pending_read_domains = I915_GEM_DOMAIN_COMMAND; - batch_obj->pending_write_domain = 0; + if (batch_obj->pending_write_domain) { + DRM_ERROR("Attempting to use self-modifying batch buffer\n"); + ret = -EINVAL; + goto err; + } + batch_obj->pending_read_domains |= I915_GEM_DOMAIN_COMMAND; /* Sanity check the batch buffer, prior to moving objects */ exec_offset = exec_list[args->buffer_count - 1].offset; |