summaryrefslogtreecommitdiffstats
path: root/drivers/gpu
diff options
context:
space:
mode:
authorKulikov Vasiliy <segooon@gmail.com>2010-11-06 15:41:16 +0100
committerDave Airlie <airlied@redhat.com>2010-11-09 04:42:15 +0100
commitdccb2a952b1f0b51978fcb3f9899c7f46ffd4b28 (patch)
treeafa1f5821dcd4e1ca2035a0fdc374bfa1ecd45cb /drivers/gpu
parentdrivers/gpu: Use vzalloc (diff)
downloadlinux-dccb2a952b1f0b51978fcb3f9899c7f46ffd4b28.tar.xz
linux-dccb2a952b1f0b51978fcb3f9899c7f46ffd4b28.zip
drm: vmwgfx: fix information leak to userland
Structure drm_vmw_fence_rep is copied to userland with field "pad64" uninitialized. It leads to leaking of contents of kernel stack memory. Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu')
-rw-r--r--drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 51d9f9f1d7f2..76954e3528c1 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -691,6 +691,7 @@ int vmw_execbuf_ioctl(struct drm_device *dev, void *data,
fence_rep.error = ret;
fence_rep.fence_seq = (uint64_t) sequence;
+ fence_rep.pad64 = 0;
user_fence_rep = (struct drm_vmw_fence_rep __user *)
(unsigned long)arg->fence_rep;