diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2011-12-14 13:56:58 +0100 |
|---|---|---|
| committer | Keith Packard <keithp@keithp.com> | 2012-01-03 19:26:07 +0100 |
| commit | 4e0e90dcb8a7df1229c69e30abebb59b0b3c2a1f (patch) | |
| tree | 8a7a8ba88526686fc71725fe54a5925c24e2687d /drivers/gpu | |
| parent | drm/i915: Add support for resetting the SO write pointers on gen7. (diff) | |
| download | linux-4e0e90dcb8a7df1229c69e30abebb59b0b3c2a1f.tar.xz linux-4e0e90dcb8a7df1229c69e30abebb59b0b3c2a1f.zip | |
drm/i915: kicking rings stuck on semaphores considered harmful
If our semaphore logic gets confused and we have a ring stuck waiting
for one, there's a decent chance it'll just execute garbage when being
kicked. Also, kicking the ring obscures the place where the error
first occured, making error_state decoding much harder.
So drop this an let gpu reset handle this mess in a clean fashion.
In contrast, kicking rings stuck on MI_WAIT is rather harmless, at
worst there'll be a bit of screen-flickering. There's also old
broken userspace out there which needs this as a work-around.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Chris Wilson <chris@hchris-wilson.co.uk>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Keith Packard <keithp@keithp.com>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_irq.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 58493114c942..5d433fc11ace 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1649,13 +1649,6 @@ static bool kick_ring(struct intel_ring_buffer *ring) I915_WRITE_CTL(ring, tmp); return true; } - if (IS_GEN6(dev) && - (tmp & RING_WAIT_SEMAPHORE)) { - DRM_ERROR("Kicking stuck semaphore on %s\n", - ring->name); - I915_WRITE_CTL(ring, tmp); - return true; - } return false; } |