diff options
author | Kees Cook <keescook@chromium.org> | 2020-06-03 22:28:45 +0200 |
---|---|---|
committer | Kees Cook <keescook@chromium.org> | 2020-07-16 21:32:25 +0200 |
commit | e909ec10186ad5cf4ecd19d0b8cf6fd96f467e58 (patch) | |
tree | 301dbdc6b2f79896d41cb970d5dfb77d00e4bf8f /drivers/hid/hid-alps.c | |
parent | drbd: Remove uninitialized_var() usage (diff) | |
download | linux-e909ec10186ad5cf4ecd19d0b8cf6fd96f467e58.tar.xz linux-e909ec10186ad5cf4ecd19d0b8cf6fd96f467e58.zip |
b43: Remove uninitialized_var() usage
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings (e.g.
"unused variable"). If the compiler thinks it is uninitialized, either
simply initialize the variable or make compiler changes. As a precursor
to removing[2] this[3] macro[4], just initialize this variable to NULL.
No later NULL deref is possible due to the early returns outside of the
(phy->rev >= 7 && phy->rev < 19) case, which explicitly tests for NULL.
[1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
[2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
[3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
[4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Fixes: 58619b14d106 ("b43: move under broadcom vendor directory")
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'drivers/hid/hid-alps.c')
0 files changed, 0 insertions, 0 deletions