diff options
| author | Thomas Weißschuh <linux@weissschuh.net> | 2024-08-03 14:34:22 +0200 |
|---|---|---|
| committer | Benjamin Tissoires <bentiss@kernel.org> | 2024-08-27 16:29:55 +0200 |
| commit | fe73965d078670406acee0218f118c0870d6a58b (patch) | |
| tree | b343efa1c3955abb57b534b7c320780fac3c9c8c /drivers/hid/hid-holtek-kbd.c | |
| parent | HID: constify hid_device::dev_rdesc (diff) | |
| download | linux-fe73965d078670406acee0218f118c0870d6a58b.tar.xz linux-fe73965d078670406acee0218f118c0870d6a58b.zip | |
HID: change return type of report_fixup() to const
By allowing the drivers to return a "const *" they can constify their
static report arrays.
This makes it clear to driver authors that the HID core will not modify
those reports and they can be reused for multiple devices.
Furthermore security is slightly improved as those reports are protected
against accidental or malicious modifications.
[bentiss: fixup hid-cougar.c and hid-multitouch.c for latest version of
the master branch]
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20240803-hid-const-fixup-v2-6-f53d7a7b29d8@weissschuh.net
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
Diffstat (limited to 'drivers/hid/hid-holtek-kbd.c')
| -rw-r--r-- | drivers/hid/hid-holtek-kbd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-holtek-kbd.c b/drivers/hid/hid-holtek-kbd.c index 1f014ac54e14..794d609c2e31 100644 --- a/drivers/hid/hid-holtek-kbd.c +++ b/drivers/hid/hid-holtek-kbd.c @@ -102,7 +102,7 @@ static __u8 holtek_kbd_rdesc_fixed[] = { 0xC0, /* End Collection */ }; -static __u8 *holtek_kbd_report_fixup(struct hid_device *hdev, __u8 *rdesc, +static const __u8 *holtek_kbd_report_fixup(struct hid_device *hdev, __u8 *rdesc, unsigned int *rsize) { struct usb_interface *intf = to_usb_interface(hdev->dev.parent); |