summaryrefslogtreecommitdiffstats
path: root/drivers/hid/hid-kye.c
diff options
context:
space:
mode:
authorJiri Kosina <jkosina@suse.cz>2014-08-21 16:57:17 +0200
committerJiri Kosina <jkosina@suse.cz>2014-08-21 17:43:06 +0200
commitad3e14d7c5268c2e24477c6ef54bbdf88add5d36 (patch)
tree16cca10139ef4caef5287bf5e7c4618da826d999 /drivers/hid/hid-kye.c
parentHID: logitech: fix bounds checking on LED report size (diff)
downloadlinux-ad3e14d7c5268c2e24477c6ef54bbdf88add5d36.tar.xz
linux-ad3e14d7c5268c2e24477c6ef54bbdf88add5d36.zip
HID: logitech: perform bounds checking on device_id early enough
device_index is a char type and the size of paired_dj_deivces is 7 elements, therefore proper bounds checking has to be applied to device_index before it is used. We are currently performing the bounds checking in logi_dj_recv_add_djhid_device(), which is too late, as malicious device could send REPORT_TYPE_NOTIF_DEVICE_UNPAIRED early enough and trigger the problem in one of the report forwarding functions called from logi_dj_raw_event(). Fix this by performing the check at the earliest possible ocasion in logi_dj_raw_event(). Cc: stable@vger.kernel.org Reported-by: Ben Hawkes <hawkes@google.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-kye.c')
0 files changed, 0 insertions, 0 deletions