diff options
| author | Xiongfeng Wang <xiongfeng.wang@linaro.org> | 2018-01-09 13:23:32 +0100 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2018-02-16 13:36:50 +0100 |
| commit | 336fd4f5f25157e9e8bd50e898a1bbcd99eaea46 (patch) | |
| tree | 5d3e78c6dd76eae8c5ed14e9f8716ea56a37ebbc /drivers/hid/uhid.c | |
| parent | HID: asus: make array 'buf' static const (diff) | |
| download | linux-336fd4f5f25157e9e8bd50e898a1bbcd99eaea46.tar.xz linux-336fd4f5f25157e9e8bd50e898a1bbcd99eaea46.zip | |
HID: uhid: use strlcpy() instead of strncpy()
gcc-8 reports
drivers/hid/uhid.c: In function 'uhid_dev_create2':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
be truncated copying 127 bytes from a string of length 127
[-Wstringop-truncation]
The compiler require that the input param 'len' of strncpy() should be
greater than the length of the src string, so that '\0' is copied as
well. We can just use strlcpy() to avoid this warning.
Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/uhid.c')
| -rw-r--r-- | drivers/hid/uhid.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index fc43850a155e..39b60e531183 100644 --- a/drivers/hid/uhid.c +++ b/drivers/hid/uhid.c @@ -496,12 +496,12 @@ static int uhid_dev_create2(struct uhid_device *uhid, goto err_free; } - len = min(sizeof(hid->name), sizeof(ev->u.create2.name)) - 1; - strncpy(hid->name, ev->u.create2.name, len); - len = min(sizeof(hid->phys), sizeof(ev->u.create2.phys)) - 1; - strncpy(hid->phys, ev->u.create2.phys, len); - len = min(sizeof(hid->uniq), sizeof(ev->u.create2.uniq)) - 1; - strncpy(hid->uniq, ev->u.create2.uniq, len); + len = min(sizeof(hid->name), sizeof(ev->u.create2.name)); + strlcpy(hid->name, ev->u.create2.name, len); + len = min(sizeof(hid->phys), sizeof(ev->u.create2.phys)); + strlcpy(hid->phys, ev->u.create2.phys, len); + len = min(sizeof(hid->uniq), sizeof(ev->u.create2.uniq)); + strlcpy(hid->uniq, ev->u.create2.uniq, len); hid->ll_driver = &uhid_hid_driver; hid->bus = ev->u.create2.bus; |