diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2009-07-22 18:30:07 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-07-22 18:30:07 +0200 |
| commit | 1fd1f285369d992950a5411139a23f0f5804727a (patch) | |
| tree | 1cd4fbc78549c4377281735bb8e3a6de1afe4197 /drivers/hid/usbhid/hiddev.c | |
| parent | perf: fix stack data leak (diff) | |
| parent | HID: Move dereferences below a NULL test (diff) | |
| download | linux-1fd1f285369d992950a5411139a23f0f5804727a.tar.xz linux-1fd1f285369d992950a5411139a23f0f5804727a.zip | |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid:
HID: Move dereferences below a NULL test
HID: hiddev, fix lock imbalance
Diffstat (limited to 'drivers/hid/usbhid/hiddev.c')
| -rw-r--r-- | drivers/hid/usbhid/hiddev.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c index 9e9421525fb9..215b2addddbb 100644 --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c @@ -527,8 +527,10 @@ static noinline int hiddev_ioctl_usage(struct hiddev *hiddev, unsigned int cmd, goto goodreturn; case HIDIOCGCOLLECTIONINDEX: + i = field->usage[uref->usage_index].collection_index; + unlock_kernel(); kfree(uref_multi); - return field->usage[uref->usage_index].collection_index; + return i; case HIDIOCGUSAGES: for (i = 0; i < uref_multi->num_values; i++) uref_multi->values[i] = |