summaryrefslogtreecommitdiffstats
path: root/drivers/hid/usbhid
diff options
context:
space:
mode:
authorGanapathi Bhat <gbhat@marvell.com>2018-06-01 12:41:20 +0200
committerKalle Valo <kvalo@codeaurora.org>2018-06-24 19:00:46 +0200
commitf8c095f679625a26efc7bb1b8c4b3c6fcaef4633 (patch)
tree1586506d11251296a276d3dbf75939095d1208ba /drivers/hid/usbhid
parentRevert "mwifiex: handle race during mwifiex_usb_disconnect" (diff)
downloadlinux-f8c095f679625a26efc7bb1b8c4b3c6fcaef4633.tar.xz
linux-f8c095f679625a26efc7bb1b8c4b3c6fcaef4633.zip
mwifiex: handle race during mwifiex_usb_disconnect
Race condition is observed during rmmod of mwifiex_usb: 1. The rmmod thread will call mwifiex_usb_disconnect(), download SHUTDOWN command and do wait_event_interruptible_timeout(), waiting for response. 2. The main thread will handle the response and will do a wake_up_interruptible(), unblocking rmmod thread. 3. On getting unblocked, rmmod thread will make rx_cmd.urb = NULL in mwifiex_usb_free(). 4. The main thread will try to resubmit rx_cmd.urb in mwifiex_usb_submit_rx_urb(), which is NULL. To fix this, move mwifiex_usb_free() from mwifiex_usb_disconnect to mwifiex_unregister_dev(). Function mwifiex_unregister_dev() is called after flushing the command and RX work queues. Suggested-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com> Reviewed-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/hid/usbhid')
0 files changed, 0 insertions, 0 deletions