summaryrefslogtreecommitdiffstats
path: root/drivers/hid
diff options
context:
space:
mode:
authorBen Hutchings <ben@decadent.org.uk>2013-11-30 20:12:27 +0100
committerJiri Kosina <jkosina@suse.cz>2013-12-02 15:17:04 +0100
commit0a5f99cfff2297f6c350b7f54878cbbf1b1253d5 (patch)
treeeff8e719cc68f46c6cb1d8f3598fd8f9d30fedc0 /drivers/hid
parentHID: uhid: fix leak for 64/32 UHID_CREATE (diff)
downloadlinux-0a5f99cfff2297f6c350b7f54878cbbf1b1253d5.tar.xz
linux-0a5f99cfff2297f6c350b7f54878cbbf1b1253d5.zip
HID: kye: Fix missing break in kye_report_fixup()
The change to support Genius Manticore Keyboard also changed behaviour for Genius Gx Imperator Keyboard, as there is no break between the cases. This is presumably a mistake. Reported by Coverity as CID 1134029. Fixes: 4a2c94c9b6c0 ('HID: kye: Add report fixup for Genius Manticore Keyboard') Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
-rw-r--r--drivers/hid/hid-kye.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c
index ecb5ca669e97..e77696367591 100644
--- a/drivers/hid/hid-kye.c
+++ b/drivers/hid/hid-kye.c
@@ -341,6 +341,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc,
case USB_DEVICE_ID_GENIUS_GX_IMPERATOR:
rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83,
"Genius Gx Imperator Keyboard");
+ break;
case USB_DEVICE_ID_GENIUS_MANTICORE:
rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104,
"Genius Manticore Keyboard");