summaryrefslogtreecommitdiffstats
path: root/drivers/hid
diff options
context:
space:
mode:
authorPablo Ceballos <pceballos@google.com>2020-11-03 01:29:39 +0100
committerJiri Kosina <jkosina@suse.cz>2020-11-05 11:09:28 +0100
commit34a9fa2025d9d3177c99351c7aaf256c5f50691f (patch)
tree8b224c58432f926f1eac9510c77bcbf09a6e58aa /drivers/hid
parentHID: i2c-hid: Put ACPI enumerated devices in D3 on shutdown (diff)
downloadlinux-34a9fa2025d9d3177c99351c7aaf256c5f50691f.tar.xz
linux-34a9fa2025d9d3177c99351c7aaf256c5f50691f.zip
HID: hid-sensor-hub: Fix issue with devices with no report ID
Some HID devices don't use a report ID because they only have a single report. In those cases, the report ID in struct hid_report will be zero and the data for the report will start at the first byte, so don't skip over the first byte. Signed-off-by: Pablo Ceballos <pceballos@google.com> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
-rw-r--r--drivers/hid/hid-sensor-hub.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 94c7398b5c27..3dd7d3246737 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -483,7 +483,8 @@ static int sensor_hub_raw_event(struct hid_device *hdev,
return 1;
ptr = raw_data;
- ptr++; /* Skip report id */
+ if (report->id)
+ ptr++; /* Skip report id */
spin_lock_irqsave(&pdata->lock, flags);