diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2017-04-25 11:20:41 +0200 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2017-06-08 13:21:43 +0200 |
| commit | 4a8557de7fb0be63e4e783ad4ad77463afb0d611 (patch) | |
| tree | 37d1e30af4a132d30b7fbdf13ffc42fd5e561445 /drivers/hsi | |
| parent | HSI: nokia-modem: Add a space character for better code readability in nokia_... (diff) | |
| download | linux-4a8557de7fb0be63e4e783ad4ad77463afb0d611.tar.xz linux-4a8557de7fb0be63e4e783ad4ad77463afb0d611.zip | |
HSI: omap_ssi: Use devm_kcalloc() in ssi_add_controller()
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data type by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Diffstat (limited to 'drivers/hsi')
| -rw-r--r-- | drivers/hsi/controllers/omap_ssi_core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c index 9a29b34ed2c8..464db6d33afb 100644 --- a/drivers/hsi/controllers/omap_ssi_core.c +++ b/drivers/hsi/controllers/omap_ssi_core.c @@ -421,8 +421,8 @@ static int ssi_add_controller(struct hsi_controller *ssi, goto out_err; } - omap_ssi->port = devm_kzalloc(&ssi->device, - sizeof(struct omap_ssi_port *) * ssi->num_ports, GFP_KERNEL); + omap_ssi->port = devm_kcalloc(&ssi->device, ssi->num_ports, + sizeof(*omap_ssi->port), GFP_KERNEL); if (!omap_ssi->port) { err = -ENOMEM; goto out_err; |