diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-10-31 08:43:37 +0100 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2022-11-17 22:49:39 +0100 |
| commit | 1aff514e1d2bd47854dbbdf867970b9d463d4c57 (patch) | |
| tree | 3f9644f2a4b390b8e4f0b8285e76af46ff688b46 /drivers/hsi | |
| parent | HSI: omap_ssi_core: fix unbalanced pm_runtime_disable() (diff) | |
| download | linux-1aff514e1d2bd47854dbbdf867970b9d463d4c57.tar.xz linux-1aff514e1d2bd47854dbbdf867970b9d463d4c57.zip | |
HSI: omap_ssi_core: fix possible memory leak in ssi_probe()
If ssi_add_controller() returns error, it should call hsi_put_controller()
to give up the reference that was set in hsi_alloc_controller(), so that
it can call hsi_controller_release() to free controller and ports that
allocated in hsi_alloc_controller().
Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/hsi')
| -rw-r--r-- | drivers/hsi/controllers/omap_ssi_core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c index b23a576ed88a..052cf3e92dd6 100644 --- a/drivers/hsi/controllers/omap_ssi_core.c +++ b/drivers/hsi/controllers/omap_ssi_core.c @@ -502,8 +502,10 @@ static int ssi_probe(struct platform_device *pd) platform_set_drvdata(pd, ssi); err = ssi_add_controller(ssi, pd); - if (err < 0) + if (err < 0) { + hsi_put_controller(ssi); goto out1; + } pm_runtime_enable(&pd->dev); |