diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-05-06 10:48:51 +0200 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2022-05-10 15:35:25 +0200 |
| commit | 0668e8ccd33122a350629f6583c880b62b40ab5d (patch) | |
| tree | 86d265a0ad03f9d7cbaf66898e9f0f0031948a57 /drivers/hte/hte-tegra194-test.c | |
| parent | hte: Remove unused including <linux/version.h> (diff) | |
| download | linux-0668e8ccd33122a350629f6583c880b62b40ab5d.tar.xz linux-0668e8ccd33122a350629f6583c880b62b40ab5d.zip | |
hte: Fix possible use-after-free in tegra_hte_test_remove()
del_timer() does not wait until the timer handler finishing.
This means that the timer handler may still be running after
the driver's remove function has finished, which would result
in a use-after-free.
Fix it by calling del_timer_sync(), which makes sure the timer
handler has finished.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Dipen Patel <dipenp@nvidia.com>
Acked-by: Dipen Patel <dipenp@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers/hte/hte-tegra194-test.c')
| -rw-r--r-- | drivers/hte/hte-tegra194-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c index 6a3e57b57a34..5d776a185bd6 100644 --- a/drivers/hte/hte-tegra194-test.c +++ b/drivers/hte/hte-tegra194-test.c @@ -219,7 +219,7 @@ static int tegra_hte_test_remove(struct platform_device *pdev) free_irq(hte.gpio_in_irq, &hte); gpiod_put(hte.gpio_in); gpiod_put(hte.gpio_out); - del_timer(&hte.timer); + del_timer_sync(&hte.timer); return 0; } |