diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-08-05 03:59:49 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2014-08-06 02:49:01 +0200 |
| commit | e981429557cbe10c780fab1c1a237cb832757652 (patch) | |
| tree | 10d9b16dbdbc5fed5d55b5474e1422d2fcb094c7 /drivers/hwmon/ads1015.c | |
| parent | hwmon: (lm92) Prevent overflow problem when writing large limits (diff) | |
| download | linux-e981429557cbe10c780fab1c1a237cb832757652.tar.xz linux-e981429557cbe10c780fab1c1a237cb832757652.zip | |
hwmon: (ads1015) Fix out-of-bounds array access
Current code uses data_rate as array index in ads1015_read_adc() and uses pga
as array index in ads1015_reg_to_mv, so we must make sure both data_rate and
pga settings are in valid value range.
Return -EINVAL if the setting is out-of-range.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/ads1015.c')
| -rw-r--r-- | drivers/hwmon/ads1015.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c index 22e0c926989d..126516414c11 100644 --- a/drivers/hwmon/ads1015.c +++ b/drivers/hwmon/ads1015.c @@ -212,6 +212,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) dev_err(&client->dev, "invalid gain on %s\n", node->full_name); + return -EINVAL; } } @@ -222,6 +223,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) dev_err(&client->dev, "invalid data_rate on %s\n", node->full_name); + return -EINVAL; } } |