diff options
| author | Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> | 2024-01-22 16:49:52 +0100 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2024-01-26 19:39:53 +0100 |
| commit | 97aab852c4b9e1b378de48a55f8c9b8d76c36ccc (patch) | |
| tree | fa7dec8628643358a636723a67cdea2ce2a7ee95 /drivers/hwmon/gigabyte_waterforce.c | |
| parent | Linux 6.8-rc1 (diff) | |
| download | linux-97aab852c4b9e1b378de48a55f8c9b8d76c36ccc.tar.xz linux-97aab852c4b9e1b378de48a55f8c9b8d76c36ccc.zip | |
hwmon: gigabyte_waterforce: Fix locking bug in waterforce_get_status()
Goto 'unlock_and_return' for unlocking before returning on the error
path.
Fixes: d5939a793693 ("hwmon: Add driver for Gigabyte AORUS Waterforce AIO coolers")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20240122154952.2851934-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/gigabyte_waterforce.c')
| -rw-r--r-- | drivers/hwmon/gigabyte_waterforce.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/gigabyte_waterforce.c b/drivers/hwmon/gigabyte_waterforce.c index 85e523775714..8129d7b3ceaf 100644 --- a/drivers/hwmon/gigabyte_waterforce.c +++ b/drivers/hwmon/gigabyte_waterforce.c @@ -146,7 +146,7 @@ static int waterforce_get_status(struct waterforce_data *priv) /* Send command for getting status */ ret = waterforce_write_expanded(priv, get_status_cmd, GET_STATUS_CMD_LENGTH); if (ret < 0) - return ret; + goto unlock_and_return; ret = wait_for_completion_interruptible_timeout(&priv->status_report_received, msecs_to_jiffies(STATUS_VALIDITY)); |