diff options
| author | Jean Delvare <khali@linux-fr.org> | 2005-07-27 22:14:49 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-09-05 18:14:14 +0200 |
| commit | 7bef559455fc71f66f8573cc1aafe1dd33966c1c (patch) | |
| tree | 6c342574710f730d39bf5383f81eaa9f9bb10a25 /drivers/hwmon/gl520sm.c | |
| parent | [PATCH] I2C: W83792D documentation 3/3 (diff) | |
| download | linux-7bef559455fc71f66f8573cc1aafe1dd33966c1c.tar.xz linux-7bef559455fc71f66f8573cc1aafe1dd33966c1c.zip | |
[PATCH] I2C: refactor message in i2c_detach_client
We could refactor the error message 34 different i2c drivers print if
i2c_detach_client() fails in this function itself. Saves quite a few
lines of code. Documentation is updated to reflect that change.
Note that this patch should be applied after Rudolf Marek's w83792d
patches.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/hwmon/gl520sm.c')
| -rw-r--r-- | drivers/hwmon/gl520sm.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/hwmon/gl520sm.c b/drivers/hwmon/gl520sm.c index b129d153deab..ff71eb7ac681 100644 --- a/drivers/hwmon/gl520sm.c +++ b/drivers/hwmon/gl520sm.c @@ -654,11 +654,8 @@ static int gl520_detach_client(struct i2c_client *client) hwmon_device_unregister(data->class_dev); - if ((err = i2c_detach_client(client))) { - dev_err(&client->dev, "Client deregistration failed, " - "client not detached.\n"); + if ((err = i2c_detach_client(client))) return err; - } kfree(data); return 0; |