diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-08-02 07:36:38 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2014-08-04 16:27:50 +0200 |
| commit | 2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020 (patch) | |
| tree | a4a81cb708b06dc65da7d38ffc3ff0a4050ef858 /drivers/hwmon/gpio-fan.c | |
| parent | hwmon: (ibmpowernv) Use of_property_read_u32 at appropriate place (diff) | |
| download | linux-2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020.tar.xz linux-2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020.zip | |
hwmon: (gpio-fan) Prevent overflow problem when writing large limits
On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value
larger than MAXINT will result in unpredictable limit values written to the
chip. Avoid auto-conversion from unsigned long to int to fix the problem.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/gpio-fan.c')
| -rw-r--r-- | drivers/hwmon/gpio-fan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index a43e5b004eb8..4efa1734bdad 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -173,7 +173,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data) return -ENODEV; } -static int rpm_to_speed_index(struct gpio_fan_data *fan_data, int rpm) +static int rpm_to_speed_index(struct gpio_fan_data *fan_data, unsigned long rpm) { struct gpio_fan_speed *speed = fan_data->speed; int i; |