diff options
| author | Christophe Jaillet <christophe.jaillet@wanadoo.fr> | 2017-09-23 08:44:15 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2017-10-01 17:46:54 +0200 |
| commit | 74007ae6316ebe40260e44f8ab558f9b1ccc04e5 (patch) | |
| tree | 4d5b01ecdd6263d930608d98037e7d5146a6b628 /drivers/hwmon/hih6130.c | |
| parent | Linux 4.14-rc1 (diff) | |
| download | linux-74007ae6316ebe40260e44f8ab558f9b1ccc04e5.tar.xz linux-74007ae6316ebe40260e44f8ab558f9b1ccc04e5.zip | |
hwmon: (xgene) Fix up error handling path mixup in 'xgene_hwmon_probe()'
Commit 2ca492e22cb7 has moved the call to 'kfifo_alloc()' from after the
main 'if' statement to before it.
But it has not updated the error handling paths accordingly.
Fix all that:
- if 'kfifo_alloc()' fails we can return directly
- direct returns after 'kfifo_alloc()' must now go to 'out_mbox_free'
- 'goto out_mbox_free' must be replaced by 'goto out', otherwise the
'[pcc_]mbox_free_channel()' call will be missed.
Fixes: 2ca492e22cb7 ("hwmon: (xgene) Fix crash when alarm occurs before driver probe")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/hih6130.c')
0 files changed, 0 insertions, 0 deletions