diff options
| author | Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-06 15:21:30 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2019-07-09 03:11:32 +0200 |
| commit | 9f7546570bcb20debfaa97bcf720fa0fcb8fc05a (patch) | |
| tree | 9473f5b1ea6c5edf19e64b2a9c3a4537ea8d2e88 /drivers/hwmon/ina3221.c | |
| parent | hwmon: (gpio-fan) fix sysfs notifications and udev events for gpio-fan alarms (diff) | |
| download | linux-9f7546570bcb20debfaa97bcf720fa0fcb8fc05a.tar.xz linux-9f7546570bcb20debfaa97bcf720fa0fcb8fc05a.zip | |
hwmon: (ina3221) Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190706132130.3129-1-nishkadg.linux@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/ina3221.c')
| -rw-r--r-- | drivers/hwmon/ina3221.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c index 55943b4dcc7b..0037e2bdacd6 100644 --- a/drivers/hwmon/ina3221.c +++ b/drivers/hwmon/ina3221.c @@ -713,8 +713,10 @@ static int ina3221_probe_from_dt(struct device *dev, struct ina3221_data *ina) for_each_child_of_node(np, child) { ret = ina3221_probe_child_from_dt(dev, child, ina); - if (ret) + if (ret) { + of_node_put(child); return ret; + } } return 0; |