diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2012-06-19 07:30:51 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2012-07-22 06:48:44 +0200 |
| commit | 0ef63e48f0247a9f9b9ffeef0f2641ac880728ab (patch) | |
| tree | d26df8fe26b65b86669bb7efb3867d1b66a18fdc /drivers/hwmon/ntc_thermistor.c | |
| parent | hwmon: (w83l785ts) Convert to use devm_ functions (diff) | |
| download | linux-0ef63e48f0247a9f9b9ffeef0f2641ac880728ab.tar.xz linux-0ef63e48f0247a9f9b9ffeef0f2641ac880728ab.zip | |
hwmon: (ntc_thermistor) Ensure that data->name string is terminated
Fix Coverity warning: Calling strncpy with a maximum size argument of 20 bytes
on destination array "data->name" of size 20 bytes might leave the destination
string unterminated.
Fix by replacing strncpy() with strlcpy() and by using sizeof() to determine
the maximum string length.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers/hwmon/ntc_thermistor.c')
| -rw-r--r-- | drivers/hwmon/ntc_thermistor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c index 6da9696e1827..74a6c58d0218 100644 --- a/drivers/hwmon/ntc_thermistor.c +++ b/drivers/hwmon/ntc_thermistor.c @@ -351,7 +351,7 @@ static int __devinit ntc_thermistor_probe(struct platform_device *pdev) data->dev = &pdev->dev; data->pdata = pdata; - strncpy(data->name, pdev->id_entry->name, PLATFORM_NAME_SIZE); + strlcpy(data->name, pdev->id_entry->name, sizeof(data->name)); switch (pdev->id_entry->driver_data) { case TYPE_NCPXXWB473: |