diff options
| author | Nathan Chancellor <natechancellor@gmail.com> | 2018-09-16 02:05:07 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2018-10-11 05:37:13 +0200 |
| commit | a31796c30e423f58d266df30a9bbf321fc071b30 (patch) | |
| tree | ebbaea3d57f44f504a5c49279454c8c324227e38 /drivers/hwmon/scmi-hwmon.c | |
| parent | hwmon: (asus_atk0110) Use PTR_ERR_OR_ZERO instead of reimplementing its function (diff) | |
| download | linux-a31796c30e423f58d266df30a9bbf321fc071b30.tar.xz linux-a31796c30e423f58d266df30a9bbf321fc071b30.zip | |
hwmon: (scmi) Remove redundant pointer check
Clang warns when the address of a pointer is used in a boolean context
as it will always return true.
drivers/hwmon/scmi-hwmon.c:59:24: warning: address of array
'sensor->name' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (sensor && sensor->name)
~~ ~~~~~~~~^~~~
1 warning generated.
Remove the check as it isn't doing anything currently; if validation
of the contents of the data structure was intended by the original
author (since this line has been present from the first version of
this driver), it can be added in a follow-up patch.
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/scmi-hwmon.c')
| -rw-r--r-- | drivers/hwmon/scmi-hwmon.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index 91976b6ca300..2e005edee0c9 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -56,7 +56,7 @@ scmi_hwmon_is_visible(const void *drvdata, enum hwmon_sensor_types type, const struct scmi_sensors *scmi_sensors = drvdata; sensor = *(scmi_sensors->info[type] + channel); - if (sensor && sensor->name) + if (sensor) return S_IRUGO; return 0; |