summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/tmp421.c
diff options
context:
space:
mode:
authorWan Jiabing <wanjiabing@vivo.com>2021-10-18 14:15:37 +0200
committerGuenter Roeck <linux@roeck-us.net>2021-10-18 16:23:21 +0200
commit66ae4d562b6a8eb2e54d051f31350b1bd5fa3d9c (patch)
treefe5cd476a71b843e1f92b5e5c5cd2b558a4d1b04 /drivers/hwmon/tmp421.c
parenthwmon: (max31722) Warn about failure to put device in stand-by in .remove() (diff)
downloadlinux-66ae4d562b6a8eb2e54d051f31350b1bd5fa3d9c.tar.xz
linux-66ae4d562b6a8eb2e54d051f31350b1bd5fa3d9c.zip
hwmon: (tmp421) Add of_node_put() before return
Fix following coccicheck warning: ./drivers/hwmon/tmp421.c:416:1-23: WARNING: Function for_each_child_of_node should have of_node_put() before return. Early exits from for_each_child_of_node should decrement the node reference counter. Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Link: https://lore.kernel.org/r/20211018121538.16482-1-wanjiabing@vivo.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/tmp421.c')
-rw-r--r--drivers/hwmon/tmp421.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
index 31e95b5749c8..1fd8d41d90c8 100644
--- a/drivers/hwmon/tmp421.c
+++ b/drivers/hwmon/tmp421.c
@@ -418,8 +418,10 @@ static int tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *d
continue;
err = tmp421_probe_child_from_dt(client, child, data);
- if (err)
+ if (err) {
+ of_node_put(child);
return err;
+ }
}
return 0;