summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/w83793.c
diff options
context:
space:
mode:
authorKirill Smelkov <kirr@nexedi.com>2019-03-27 09:33:01 +0100
committerKirill Smelkov <kirr@nexedi.com>2019-05-06 16:45:51 +0200
commit184012ad69b275a17d6fa40a8d4dcf15ef76c4d2 (patch)
treea9e4fa265380cbec647d7609dc6a950357ed4852 /drivers/hwmon/w83793.c
parentLinux 5.1 (diff)
downloadlinux-184012ad69b275a17d6fa40a8d4dcf15ef76c4d2.tar.xz
linux-184012ad69b275a17d6fa40a8d4dcf15ef76c4d2.zip
dtlk: remove double call to nonseekable_open
dtlk_open currently has 2 calls to nonseekable_open which are both executed on success path. It was not hurting to make the extra call as nonseekable_open is only changing file->f_flags in idempotent way. However the first nonseekable_open is indeed both unneeded and looks suspicious. The first nonseekable_open was added in 6244f13c51 ("Fix up a couple of drivers - notable sg - for nonseekability."; 2004-Aug-7). The second nonseekable_open call was introduced in dc5c724584 ("Remove ESPIPE logic from drivers, letting the VFS layer handle it instead.; 2004-Aug-8). The latter patch being mass change probably missed to remove nonseekable_open that was introduced into dtlk_open the day before. Fix it: remove the extra/unneeded nonseekable_open call and leave the call to nonseekable_open only on the path where we are actually opening the file. Suggested-by: Pavel Machek <pavel@denx.de> Signed-off-by: Kirill Smelkov <kirr@nexedi.com>
Diffstat (limited to 'drivers/hwmon/w83793.c')
0 files changed, 0 insertions, 0 deletions