diff options
author | Crt Mori <cmo@melexis.com> | 2015-10-02 14:24:21 +0200 |
---|---|---|
committer | Jonathan Cameron <jic23@kernel.org> | 2015-10-03 11:15:25 +0200 |
commit | 1de953e77b8c8b8cb6f734733cf20e95a1b0fbb8 (patch) | |
tree | a482c774bd4097f91bff9a84f6aa061be16106ff /drivers/hwmon | |
parent | iio: mcp4531: Driver for Microchip digital potentiometers (diff) | |
download | linux-1de953e77b8c8b8cb6f734733cf20e95a1b0fbb8.tar.xz linux-1de953e77b8c8b8cb6f734733cf20e95a1b0fbb8.zip |
iio: mlx96014: Error checking from positive to negative
Dan Carpenter reported a static checker report and after his mail I
noticed that we actually return from function if positive value is
obtained from i2c read. This was remainder from when code was not in
separate function (which I changed during the review process).
Static checker reported
drivers/iio/temperature/mlx90614.c:167
mlx90614_iir_search()
warn: this cast is a no-op
which meant that cast before negating is useless. Dan also proposed a
solution on nicer bit operation form.
Also changed magic number to macro in process as that was confusing.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Crt Mori <cmo@melexis.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/hwmon')
0 files changed, 0 insertions, 0 deletions