diff options
| author | amy.shih <amy.shih@advantech.com.tw> | 2019-09-18 10:48:00 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2019-10-02 15:34:26 +0200 |
| commit | 539ad001d1557731cb38d4a9d0e8e16244b2d913 (patch) | |
| tree | 34bf3d31c1c482da1afaf4e339b19e5e54a7eafe /drivers/hwmon | |
| parent | Linux 5.4-rc1 (diff) | |
| download | linux-539ad001d1557731cb38d4a9d0e8e16244b2d913.tar.xz linux-539ad001d1557731cb38d4a9d0e8e16244b2d913.zip | |
hwmon: (nct7904) Fix the incorrect value of vsen_mask in nct7904_data struct
Voltage sensors overlap with external temperature sensors. Detect
the multi-function of voltage, thermal diode and thermistor from
register VT_ADC_MD_REG to set value of vsen_mask in nct7904_data
struct.
Signed-off-by: amy.shih <amy.shih@advantech.com.tw>
Link: https://lore.kernel.org/r/20190918084801.9859-1-Amy.Shih@advantech.com.tw
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/nct7904.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c index 95b447cfa24c..f62dd1882451 100644 --- a/drivers/hwmon/nct7904.c +++ b/drivers/hwmon/nct7904.c @@ -915,12 +915,15 @@ static int nct7904_probe(struct i2c_client *client, data->temp_mode = 0; for (i = 0; i < 4; i++) { - val = (ret & (0x03 << i)) >> (i * 2); + val = (ret >> (i * 2)) & 0x03; bit = (1 << i); - if (val == 0) + if (val == 0) { data->tcpu_mask &= ~bit; - else if (val == 0x1 || val == 0x2) - data->temp_mode |= bit; + } else { + if (val == 0x1 || val == 0x2) + data->temp_mode |= bit; + data->vsen_mask &= ~(0x06 << (i * 2)); + } } /* PECI */ |