diff options
| author | Cosmo Chou <chou.cosmo@gmail.com> | 2024-08-19 12:46:30 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2024-08-27 05:58:05 +0200 |
| commit | 7bbc079531fc38d401e1c4088d4981435a8828e3 (patch) | |
| tree | 1ae7c8e3b4d397bb4b2483c399d9051e94ae38f0 /drivers/hwmon | |
| parent | hwmon: (asus-ec-sensors) remove VRM temp X570-E GAMING (diff) | |
| download | linux-7bbc079531fc38d401e1c4088d4981435a8828e3.tar.xz linux-7bbc079531fc38d401e1c4088d4981435a8828e3.zip | |
hwmon: (pt5161l) Fix invalid temperature reading
The temperature reading function was using a signed long for the ADC
code, which could lead to mishandling of invalid codes on 32-bit
platforms. This allowed out-of-range ADC codes to be incorrectly
interpreted as valid values and used in temperature calculations.
Change adc_code to u32 to ensure that invalid ADC codes are correctly
identified on all platforms.
Fixes: 1b2ca93cd059 ("hwmon: Add driver for Astera Labs PT5161L retimer")
Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
Message-ID: <20240819104630.2375441-1-chou.cosmo@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/pt5161l.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hwmon/pt5161l.c b/drivers/hwmon/pt5161l.c index b0d58a26d499..a9f0b23f9e76 100644 --- a/drivers/hwmon/pt5161l.c +++ b/drivers/hwmon/pt5161l.c @@ -427,7 +427,7 @@ static int pt5161l_read(struct device *dev, enum hwmon_sensor_types type, struct pt5161l_data *data = dev_get_drvdata(dev); int ret; u8 buf[8]; - long adc_code; + u32 adc_code; switch (attr) { case hwmon_temp_input: @@ -449,7 +449,7 @@ static int pt5161l_read(struct device *dev, enum hwmon_sensor_types type, adc_code = buf[3] << 24 | buf[2] << 16 | buf[1] << 8 | buf[0]; if (adc_code == 0 || adc_code >= 0x3ff) { - dev_dbg(dev, "Invalid adc_code %lx\n", adc_code); + dev_dbg(dev, "Invalid adc_code %x\n", adc_code); return -EIO; } |