diff options
| author | Konstantin Aladyshev <aladyshev22@gmail.com> | 2024-01-27 16:48:44 +0100 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2024-01-27 17:03:18 +0100 |
| commit | 915644189c22d9c93e9fee7c7c993b58e745bef7 (patch) | |
| tree | 96dc06c4cd7d9d1100dcc00406d32081c78d0997 /drivers/hwmon | |
| parent | hwmon: (pmbus/mp2975) Fix driver initialization for MP2975 device (diff) | |
| download | linux-915644189c22d9c93e9fee7c7c993b58e745bef7.tar.xz linux-915644189c22d9c93e9fee7c7c993b58e745bef7.zip | |
hwmon: (pmbus/mp2975) Correct comment inside 'mp2975_read_byte_data'
The current driver code no longer perfrom internal conversion from
VID to direct. Instead it configures READ_VOUT using MFR_DC_LOOP_CTRL.
Correct the comment message inside the 'mp2975_read_byte_data'
function to match the driver logic.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Fixes: c60fe56c169e ("hwmon: (pmbus/mp2975) Fix driver initialization for MP2975 device")
Link: https://lore.kernel.org/r/20240127154844.989-1-aladyshev22@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/pmbus/mp2975.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/hwmon/pmbus/mp2975.c b/drivers/hwmon/pmbus/mp2975.c index 5bbfdacb61a7..e5fa10b3b8bc 100644 --- a/drivers/hwmon/pmbus/mp2975.c +++ b/drivers/hwmon/pmbus/mp2975.c @@ -131,10 +131,9 @@ static int mp2975_read_byte_data(struct i2c_client *client, int page, int reg) switch (reg) { case PMBUS_VOUT_MODE: /* - * Enforce VOUT direct format, since device allows to set the - * different formats for the different rails. Conversion from - * VID to direct provided by driver internally, in case it is - * necessary. + * Report direct format as configured by MFR_DC_LOOP_CTRL. + * Unlike on MP2971/MP2973 the reported VOUT_MODE isn't automatically + * internally updated, but always reads as PB_VOUT_MODE_VID. */ return PB_VOUT_MODE_DIRECT; default: |