diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-11-30 11:51:17 +0100 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2021-12-27 00:02:06 +0100 |
| commit | 3315e716999d98d628abebbffaa82bef52962c95 (patch) | |
| tree | aacaf38c68c1db1595afcbf7f37aaa0ae3fb77c0 /drivers/hwmon | |
| parent | hwmon: (asus_wmi_ec_sensors) fix array overflow (diff) | |
| download | linux-3315e716999d98d628abebbffaa82bef52962c95.tar.xz linux-3315e716999d98d628abebbffaa82bef52962c95.zip | |
hwmon: (asus_wmi_sensors) fix an array overflow
Smatch detects this array overflow:
drivers/hwmon/asus_wmi_sensors.c:569 asus_wmi_configure_sensor_setup()
error: buffer overflow 'hwmon_attributes' 8 <= 9
The hwmon_attributes[] array should have "hwmon_max" so that it gets
larger when more attributes are added.
Fixes: 9d07e54a25b8 ("hwmon: (asus_wmi_sensors) Support X370 Asus WMI.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211130105117.GH5827@kili
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/asus_wmi_sensors.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/asus_wmi_sensors.c b/drivers/hwmon/asus_wmi_sensors.c index 67af15d99396..c80eee874b6c 100644 --- a/drivers/hwmon/asus_wmi_sensors.c +++ b/drivers/hwmon/asus_wmi_sensors.c @@ -125,7 +125,7 @@ static enum hwmon_sensor_types asus_data_types[] = { [WATER_FLOW] = hwmon_fan, }; -static u32 hwmon_attributes[] = { +static u32 hwmon_attributes[hwmon_max] = { [hwmon_chip] = HWMON_C_REGISTER_TZ, [hwmon_temp] = HWMON_T_INPUT | HWMON_T_LABEL, [hwmon_in] = HWMON_I_INPUT | HWMON_I_LABEL, |