summaryrefslogtreecommitdiffstats
path: root/drivers/i2c/busses/i2c-robotfuzz-osif.c
diff options
context:
space:
mode:
authorPeter Rosin <peda@axentia.se>2018-05-09 21:46:57 +0200
committerWolfram Sang <wsa@the-dreams.de>2018-05-24 22:12:24 +0200
commit7fb29b958dfff9c8eddfe4250aa0ed3614446c62 (patch)
tree8ab19b99e089a65a82b2508db122e325235a159f /drivers/i2c/busses/i2c-robotfuzz-osif.c
parenti2c: rk3x: Don't print visible virtual mapping MMIO address (diff)
downloadlinux-7fb29b958dfff9c8eddfe4250aa0ed3614446c62.tar.xz
linux-7fb29b958dfff9c8eddfe4250aa0ed3614446c62.zip
i2c: robotfuzz-osif: remove pointless local variable
Just use the value directly instead of assigning it to a variable first. And then drop the unused variable. Signed-off-by: Peter Rosin <peda@axentia.se> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/i2c/busses/i2c-robotfuzz-osif.c')
-rw-r--r--drivers/i2c/busses/i2c-robotfuzz-osif.c17
1 files changed, 7 insertions, 10 deletions
diff --git a/drivers/i2c/busses/i2c-robotfuzz-osif.c b/drivers/i2c/busses/i2c-robotfuzz-osif.c
index 9c0f52b7ff7e..51d93b4b00f2 100644
--- a/drivers/i2c/busses/i2c-robotfuzz-osif.c
+++ b/drivers/i2c/busses/i2c-robotfuzz-osif.c
@@ -63,26 +63,23 @@ static int osif_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs,
struct osif_priv *priv = adapter->algo_data;
struct i2c_msg *pmsg;
int ret = 0;
- int i, cmd;
+ int i;
for (i = 0; ret >= 0 && i < num; i++) {
pmsg = &msgs[i];
if (pmsg->flags & I2C_M_RD) {
- cmd = OSIFI2C_READ;
-
- ret = osif_usb_read(adapter, cmd, pmsg->flags,
- pmsg->addr, pmsg->buf,
- pmsg->len);
+ ret = osif_usb_read(adapter, OSIFI2C_READ,
+ pmsg->flags, pmsg->addr,
+ pmsg->buf, pmsg->len);
if (ret != pmsg->len) {
dev_err(&adapter->dev, "failure reading data\n");
return -EREMOTEIO;
}
} else {
- cmd = OSIFI2C_WRITE;
-
- ret = osif_usb_write(adapter, cmd, pmsg->flags,
- pmsg->addr, pmsg->buf, pmsg->len);
+ ret = osif_usb_write(adapter, OSIFI2C_WRITE,
+ pmsg->flags, pmsg->addr,
+ pmsg->buf, pmsg->len);
if (ret != pmsg->len) {
dev_err(&adapter->dev, "failure writing data\n");
return -EREMOTEIO;