diff options
| author | Andreas Hecht <andreas.e.hecht@gmail.com> | 2021-06-24 17:25:35 +0200 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2021-06-24 21:47:43 +0200 |
| commit | 3265a7e6b41bae8608e7e91ac6798de5e5564164 (patch) | |
| tree | b27f825fa9063d3a45c72a75adde8297f1887b5a /drivers/i2c | |
| parent | i2c: cp2615: check for allocation failure in cp2615_i2c_recv() (diff) | |
| download | linux-3265a7e6b41bae8608e7e91ac6798de5e5564164.tar.xz linux-3265a7e6b41bae8608e7e91ac6798de5e5564164.zip | |
i2c: dev: Add __user annotation
Fix Sparse warnings:
drivers/i2c/i2c-dev.c:546:19: warning: incorrect type in assignment (different address spaces)
drivers/i2c/i2c-dev.c:549:53: warning: incorrect type in argument 2 (different address spaces)
compat_ptr() returns a pointer tagged __user which gets assigned to a
pointer missing the __user annotation. The same pointer is passed to
copy_from_user() as an argument where it is expected to have the __user
annotation. Fix both by adding the __user annotation to the pointer.
Fixes: 7d5cb45655f2 ("i2c compat ioctls: move to ->compat_ioctl()")
Signed-off-by: Andreas Hecht <andreas.e.hecht@gmail.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/i2c-dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 6ef38a8ee95c..cb64fe649390 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -526,7 +526,7 @@ static long compat_i2cdev_ioctl(struct file *file, unsigned int cmd, unsigned lo return put_user(funcs, (compat_ulong_t __user *)arg); case I2C_RDWR: { struct i2c_rdwr_ioctl_data32 rdwr_arg; - struct i2c_msg32 *p; + struct i2c_msg32 __user *p; struct i2c_msg *rdwr_pa; int i; |