diff options
| author | Sergey Shtylyov <s.shtylyov@omprussia.ru> | 2021-04-10 22:25:10 +0200 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2021-04-14 10:21:42 +0200 |
| commit | e5b2e3e742015dd2aa6bc7bcef2cb59b2de1221c (patch) | |
| tree | e80531468138a538f075f5a90d0587d146e04f26 /drivers/i2c | |
| parent | i2c: rcar: add IRQ check (diff) | |
| download | linux-e5b2e3e742015dd2aa6bc7bcef2cb59b2de1221c.tar.xz linux-e5b2e3e742015dd2aa6bc7bcef2cb59b2de1221c.zip | |
i2c: sh7760: add IRQ check
The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code. Stop calling devm_request_irq() with invalid
IRQ #s.
Fixes: a26c20b1fa6d ("i2c: Renesas SH7760 I2C master driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-sh7760.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-sh7760.c b/drivers/i2c/busses/i2c-sh7760.c index c2005c789d2b..c79c9f542c5a 100644 --- a/drivers/i2c/busses/i2c-sh7760.c +++ b/drivers/i2c/busses/i2c-sh7760.c @@ -471,7 +471,10 @@ static int sh7760_i2c_probe(struct platform_device *pdev) goto out2; } - id->irq = platform_get_irq(pdev, 0); + ret = platform_get_irq(pdev, 0); + if (ret < 0) + return ret; + id->irq = ret; id->adap.nr = pdev->id; id->adap.algo = &sh7760_i2c_algo; |