diff options
| author | Jarkko Nikula <jarkko.nikula@linux.intel.com> | 2023-09-21 07:56:57 +0200 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2023-09-25 23:35:14 +0200 |
| commit | 361acacaf7c706223968c8186f0d3b6e214e7403 (patch) | |
| tree | 7999b51a8d6a7d3f06c7b8d4142e276f666ff964 /drivers/i3c | |
| parent | i3c: mipi-i3c-hci: Fix out of bounds access in hci_dma_irq_handler (diff) | |
| download | linux-361acacaf7c706223968c8186f0d3b6e214e7403.tar.xz linux-361acacaf7c706223968c8186f0d3b6e214e7403.zip | |
i3c: mipi-i3c-hci: Remove BUG() when Ring Abort request times out
Ring Abort request will timeout in case there is an error in the Host
Controller interrupt delivery or Ring Header configuration. Using BUG()
makes hard to debug those cases.
Make it less severe and turn BUG() to WARN_ON().
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20230921055704.1087277-6-jarkko.nikula@linux.intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/i3c')
| -rw-r--r-- | drivers/i3c/master/mipi-i3c-hci/dma.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c index 9897145895c6..e676b47966d2 100644 --- a/drivers/i3c/master/mipi-i3c-hci/dma.c +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c @@ -450,10 +450,9 @@ static bool hci_dma_dequeue_xfer(struct i3c_hci *hci, /* * We're deep in it if ever this condition is ever met. * Hardware might still be writing to memory, etc. - * Better suspend the world than risking silent corruption. */ dev_crit(&hci->master.dev, "unable to abort the ring\n"); - BUG(); + WARN_ON(1); } for (i = 0; i < n; i++) { |