summaryrefslogtreecommitdiffstats
path: root/drivers/ide
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2016-07-14 12:48:02 +0200
committerDavid S. Miller <davem@davemloft.net>2016-07-27 00:25:31 +0200
commitd4f8c2e0f827a0b3a322c449ac331ae41feeb359 (patch)
treeddb36fa3715b0177b44e2fa4c005b311aed2c3aa /drivers/ide
parentide: hpt366: fix incorrect mask when checking at cmd_high_time (diff)
downloadlinux-d4f8c2e0f827a0b3a322c449ac331ae41feeb359.tar.xz
linux-d4f8c2e0f827a0b3a322c449ac331ae41feeb359.zip
ide: missing break statement in set_timings_mdma()
There was clearly supposed to be a break statement here. Currently we use the k2 ata timings instead of sh ata ones we intended. Probably no one has this hardware anymore so it likely doesn't make a difference beyond the static checker warning. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ide')
-rw-r--r--drivers/ide/pmac.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index 7f0434f7e486..0c5d3a99468e 100644
--- a/drivers/ide/pmac.c
+++ b/drivers/ide/pmac.c
@@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
*timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
*timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
}
+ break;
case controller_un_ata6:
case controller_k2_ata6: {
/* 100Mhz cell */