diff options
| author | lramos.prof@yahoo.com.br <lramos.prof@yahoo.com.br> | 2016-10-12 03:12:45 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-12-26 17:45:12 +0100 |
| commit | b2ae75052a8c1611b2030fa49ba1c6b6439fa04f (patch) | |
| tree | f43b13c19366ad780fe96e843dfedb32d13c7980 /drivers/ide | |
| parent | Linux 4.10-rc1 (diff) | |
| download | linux-b2ae75052a8c1611b2030fa49ba1c6b6439fa04f.tar.xz linux-b2ae75052a8c1611b2030fa49ba1c6b6439fa04f.zip | |
ide: Fix interface autodetection in legacy IDE driver (trial #2)
This humble patch was sent one or two months before, and had no actions,
except for a colleague reply which friendly pointed out some formatting
problems (which were solved in a second message).
It relates to an old code, the legacy IDE driver, but the bug it
addresses is real. The code, although rarely used, is
still there to be compiled if one chooses to do so (like me).
Also, the fix has a very low risk of present collateral effects IMHO.
It is already compiled and tested in some embedded machines.
So, again IMHO, it is worth be fixed.
This email is a second trial with it. I hope it can help the one or two
guys out there which are still running the legacy IDE driver and
haven't noticed the former email.
Fixes: 20df429dd667 ("ide-generic: handle probing of legacy io-ports v5")
Signed-off-by: Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ide')
| -rw-r--r-- | drivers/ide/ide-generic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ide/ide-generic.c b/drivers/ide/ide-generic.c index 54d7c4685d23..419818a39c27 100644 --- a/drivers/ide/ide-generic.c +++ b/drivers/ide/ide-generic.c @@ -96,10 +96,10 @@ static int __init ide_generic_init(void) printk(KERN_INFO DRV_NAME ": please use \"probe_mask=0x3f\" " "module parameter for probing all legacy ISA IDE ports\n"); - if (primary == 0) + if (primary) probe_mask |= 0x1; - if (secondary == 0) + if (secondary) probe_mask |= 0x2; } else printk(KERN_INFO DRV_NAME ": enforcing probing of I/O ports " |