diff options
| author | Adrian Bunk <bunk@stusta.de> | 2005-11-21 23:32:14 +0100 |
|---|---|---|
| committer | Jody McIntyre <scjody@modernduck.com> | 2005-11-21 23:32:14 +0100 |
| commit | d734f92b0dc4c04daa2e0106354972cbbc2e0fbe (patch) | |
| tree | c0eaa2ea898f5acc05d08bbe1a2914ed4aac8cfc /drivers/ieee1394/raw1394.c | |
| parent | sbp2: slimmer interface to scsi_mod (diff) | |
| download | linux-d734f92b0dc4c04daa2e0106354972cbbc2e0fbe.tar.xz linux-d734f92b0dc4c04daa2e0106354972cbbc2e0fbe.zip | |
drivers/ieee1394/raw1394.c: fix a NULL pointer
The coverity checker spotted that this was a NULL pointer dereference in
the "if (copy_from_user(...))" case since the next step is to
kfree(cache->filled_head).
There's no need to free cache at this point, and it's getting free'd
later.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Jody McIntyre <scjody@modernduck.com>
Diffstat (limited to 'drivers/ieee1394/raw1394.c')
| -rw-r--r-- | drivers/ieee1394/raw1394.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/ieee1394/raw1394.c b/drivers/ieee1394/raw1394.c index 0278dc5d5ef9..99b2ce15db83 100644 --- a/drivers/ieee1394/raw1394.c +++ b/drivers/ieee1394/raw1394.c @@ -2131,7 +2131,6 @@ static int modify_config_rom(struct file_info *fi, struct pending_request *req) req->req.length)) { csr1212_release_keyval(fi->csr1212_dirs[dr]); fi->csr1212_dirs[dr] = NULL; - CSR1212_FREE(cache); ret = -EFAULT; } else { cache->len = req->req.length; |