diff options
| author | Jeff Garzik <jgarzik@pobox.com> | 2005-05-28 13:47:39 +0200 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@pobox.com> | 2005-06-17 19:04:37 +0200 |
| commit | e3df715501be3329986e5d9dfa9a477f49e7996b (patch) | |
| tree | 3602c4bbca8bca9b615b93099de53717bc932591 /drivers/ieee1394 | |
| parent | [SCSI] aic7xxx: fix the BIOS limits setting routines (diff) | |
| download | linux-e3df715501be3329986e5d9dfa9a477f49e7996b.tar.xz linux-e3df715501be3329986e5d9dfa9a477f49e7996b.zip | |
[SCSI] Remove unnecessary locking around completion function calls
The SCSI ->done() hook should not be called from inside a spinlock.
Drivers that do this are mostly cut-n-paste from 2.2.x-era.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/ieee1394')
| -rw-r--r-- | drivers/ieee1394/sbp2.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index aa941025072e..de552486b1c9 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c @@ -2453,8 +2453,6 @@ static void sbp2scsi_complete_command(struct scsi_id_instance_data *scsi_id, u32 scsi_status, struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd *)) { - unsigned long flags; - SBP2_DEBUG("sbp2scsi_complete_command"); /* @@ -2553,11 +2551,7 @@ static void sbp2scsi_complete_command(struct scsi_id_instance_data *scsi_id, /* * Tell scsi stack that we're done with this command */ - spin_lock_irqsave(scsi_id->scsi_host->host_lock,flags); done (SCpnt); - spin_unlock_irqrestore(scsi_id->scsi_host->host_lock,flags); - - return; } |