diff options
| author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2012-08-08 11:58:00 +0200 |
|---|---|---|
| committer | Jonathan Cameron <jic23@kernel.org> | 2012-08-16 21:24:33 +0200 |
| commit | 1c795ebd00042b3a5c97e049fd1c08763714a7a8 (patch) | |
| tree | b54a55288bec44e39acdd6f6282f6b4d568afb23 /drivers/iio/light/adjd_s311.c | |
| parent | iio: frequency: ADF4350: Fix potential reference div factor overflow. (diff) | |
| download | linux-1c795ebd00042b3a5c97e049fd1c08763714a7a8.tar.xz linux-1c795ebd00042b3a5c97e049fd1c08763714a7a8.zip | |
iio/adjd_s311: Fix potential memory leak in adjd_s311_update_scan_mode()
Do not leak memory by updating pointer with potentially NULL realloc return value.
There is no need to preserve data in the buffer,
so replace krealloc() by kfree()-kmalloc() pair.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio/light/adjd_s311.c')
| -rw-r--r-- | drivers/iio/light/adjd_s311.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/iio/light/adjd_s311.c b/drivers/iio/light/adjd_s311.c index 1cbb449b319a..9a99f43094f0 100644 --- a/drivers/iio/light/adjd_s311.c +++ b/drivers/iio/light/adjd_s311.c @@ -271,9 +271,10 @@ static int adjd_s311_update_scan_mode(struct iio_dev *indio_dev, const unsigned long *scan_mask) { struct adjd_s311_data *data = iio_priv(indio_dev); - data->buffer = krealloc(data->buffer, indio_dev->scan_bytes, - GFP_KERNEL); - if (!data->buffer) + + kfree(data->buffer); + data->buffer = kmalloc(indio_dev->scan_bytes, GFP_KERNEL); + if (data->buffer == NULL) return -ENOMEM; return 0; |