summaryrefslogtreecommitdiffstats
path: root/drivers/iio/magnetometer/st_magn_spi.c
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2016-11-09 16:09:59 +0100
committerJonathan Cameron <jic23@kernel.org>2016-11-12 16:45:37 +0100
commit57d035545165a354a52f5d16d46efbb318a2fff4 (patch)
tree3ac4e67c5fcb7fa128d74cf0f84211540b10da2c /drivers/iio/magnetometer/st_magn_spi.c
parentiio: gyro: st_gyro: inline per-sensor data (diff)
downloadlinux-57d035545165a354a52f5d16d46efbb318a2fff4.tar.xz
linux-57d035545165a354a52f5d16d46efbb318a2fff4.zip
iio: magn: st_magn: inline per-sensor data
We have #defines for all the individual sensor registers and value/mask pairs #defined at the top of the file and used at exactly one spot. This is usually good if the #defines give a meaning to the opaque magic numbers. However in this case, the semantic meaning is inherent in the name of the C99-addressable fields, and that means duplication of information, and only makes the code hard to maintain since you every time have to add a new #define AND update the site where it is to be used. Get rid of the #defines and just open code the values into the appropriate struct elements. Make sure to explicitly address the .hz and .value fields in the st_sensor_odr_avl struct so that the meaning of all values is clear. This patch is purely syntactic should have no semantic effect. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio/magnetometer/st_magn_spi.c')
0 files changed, 0 insertions, 0 deletions