summaryrefslogtreecommitdiffstats
path: root/drivers/iio
diff options
context:
space:
mode:
authorIrina Tirdea <irina.tirdea@intel.com>2015-04-13 17:40:59 +0200
committerJonathan Cameron <jic23@kernel.org>2015-04-26 20:52:35 +0200
commitef8307a21ac79823b8a4f977eac42329328af384 (patch)
tree1527eee73eec7a8c9a61705f8392d90d6a141a76 /drivers/iio
parentiio: accel: mma9553: refactor mma9553_read_raw (diff)
downloadlinux-ef8307a21ac79823b8a4f977eac42329328af384.tar.xz
linux-ef8307a21ac79823b8a4f977eac42329328af384.zip
iio: accel: mma9553: fix gpio bitnum init value
Initial value of gpio bitnum is set to -1, but the variable is declared as unsigned. Use a positive invalid value for initial gpio bitnum. Signed-off-by: Irina Tirdea <irina.tirdea@intel.com> Suggested-by: Hartmut Knaack <knaack.h@gmx.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio')
-rw-r--r--drivers/iio/accel/mma9553.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
index 032537fc2c56..9d649c4a21fd 100644
--- a/drivers/iio/accel/mma9553.c
+++ b/drivers/iio/accel/mma9553.c
@@ -77,6 +77,7 @@
/* Bitnum used for GPIO configuration = bit number in high status byte */
#define MMA9553_STATUS_TO_BITNUM(bit) (ffs(bit) - 9)
+#define MMA9553_MAX_BITNUM MMA9553_STATUS_TO_BITNUM(BIT(16))
#define MMA9553_DEFAULT_SAMPLE_RATE 30 /* Hz */
@@ -406,8 +407,8 @@ static int mma9553_init(struct mma9553_data *data)
}
- data->gpio_bitnum = -1;
/* Reset GPIO */
+ data->gpio_bitnum = MMA9553_MAX_BITNUM;
ret = mma9553_conf_gpio(data);
if (ret < 0)
return ret;