diff options
| author | Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> | 2023-01-26 16:21:46 +0100 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2023-01-28 18:37:08 +0100 |
| commit | e56d2c34ce9dc122b1a618172ec0e05e50adb9e9 (patch) | |
| tree | 36e08da148dd401e2725cebbbcf8a99ccb4d2a6c /drivers/iio | |
| parent | dt-bindings: iio/proximity: semtech,sx9360: Fix 'semtech,resolution' type (diff) | |
| download | linux-e56d2c34ce9dc122b1a618172ec0e05e50adb9e9.tar.xz linux-e56d2c34ce9dc122b1a618172ec0e05e50adb9e9.zip | |
iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_status_word()
Smatch Warns: drivers/iio/accel/mma9551_core.c:357
mma9551_read_status_word() error: uninitialized symbol 'v'.
When (offset >= 1 << 12) is true mma9551_transfer() will return -EINVAL
without 'v' being initialized, so check for the error and return.
Note: Not a bug as such because the caller checks return value and
doesn't not use this parameter in the problem case.
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230126152147.3585874-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio')
| -rw-r--r-- | drivers/iio/accel/mma9551_core.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/iio/accel/mma9551_core.c b/drivers/iio/accel/mma9551_core.c index 64ca7d7a9673..86437ddc5ca1 100644 --- a/drivers/iio/accel/mma9551_core.c +++ b/drivers/iio/accel/mma9551_core.c @@ -354,9 +354,12 @@ int mma9551_read_status_word(struct i2c_client *client, u8 app_id, ret = mma9551_transfer(client, app_id, MMA9551_CMD_READ_STATUS, reg, NULL, 0, (u8 *)&v, 2); + if (ret < 0) + return ret; + *val = be16_to_cpu(v); - return ret; + return 0; } EXPORT_SYMBOL_NS(mma9551_read_status_word, IIO_MMA9551); |