diff options
| author | Leon Romanovsky <leon@kernel.org> | 2017-10-29 20:34:35 +0100 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2017-11-13 19:53:22 +0100 |
| commit | 9950acf945f55222385d85489617e1d81e45fe34 (patch) | |
| tree | e63621afade4a07df41c85a6e6a061a3d798156e /drivers/infiniband/hw/cxgb4/qp.c | |
| parent | RDMA/bnxt_re: Remove unused vlan_tag variable (diff) | |
| download | linux-9950acf945f55222385d85489617e1d81e45fe34.tar.xz linux-9950acf945f55222385d85489617e1d81e45fe34.zip | |
RDMA/cxgb4: Protect from possible dereference
Smatch tool reports the following error:
drivers/infiniband/hw/cxgb4/qp.c:1886
c4iw_create_qp() error: we previously assumed 'ucontext'
could be null (see line 1804)
Cc: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/hw/cxgb4/qp.c')
| -rw-r--r-- | drivers/infiniband/hw/cxgb4/qp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index 57b23e33eb8b..4b3267358dff 100644 --- a/drivers/infiniband/hw/cxgb4/qp.c +++ b/drivers/infiniband/hw/cxgb4/qp.c @@ -1843,7 +1843,7 @@ struct ib_qp *c4iw_create_qp(struct ib_pd *pd, struct ib_qp_init_attr *attrs, if (ret) goto err_destroy_qp; - if (udata) { + if (udata && ucontext) { sq_key_mm = kmalloc(sizeof(*sq_key_mm), GFP_KERNEL); if (!sq_key_mm) { ret = -ENOMEM; |