summaryrefslogtreecommitdiffstats
path: root/drivers/infiniband/hw/hns
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-06-24 23:46:08 +0200
committerJason Gunthorpe <jgg@mellanox.com>2019-06-25 15:18:19 +0200
commit7ef7587541d49c6de1c9650c3c819a7fdd7ade66 (patch)
treec55d61a57c3b04e2c26686e1202056667971a7e9 /drivers/infiniband/hw/hns
parentRDMA/mlx5: Refactor MR descriptors allocation (diff)
downloadlinux-7ef7587541d49c6de1c9650c3c819a7fdd7ade66.tar.xz
linux-7ef7587541d49c6de1c9650c3c819a7fdd7ade66.zip
RDMA/hns: fix potential integer overflow on left shift
There is a potential integer overflow when int i is left shifted as this is evaluated using 32 bit arithmetic but is being used in a context that expects an expression of type dma_addr_t. Fix this by casting integer i to dma_addr_t before shifting to avoid the overflow. Addresses-Coverity: ("Unintentional integer overflow") Fixes: 2ac0bc5e725e ("RDMA/hns: Add a group interfaces for optimizing buffers getting flow") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband/hw/hns')
-rw-r--r--drivers/infiniband/hw/hns/hns_roce_alloc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/hns/hns_roce_alloc.c b/drivers/infiniband/hw/hns/hns_roce_alloc.c
index 14fcc359599c..2c8defa94107 100644
--- a/drivers/infiniband/hw/hns/hns_roce_alloc.c
+++ b/drivers/infiniband/hw/hns/hns_roce_alloc.c
@@ -257,7 +257,7 @@ int hns_roce_get_kmem_bufs(struct hns_roce_dev *hr_dev, dma_addr_t *bufs,
for (i = start; i < end; i++)
if (buf->nbufs == 1)
bufs[total++] = buf->direct.map +
- (i << buf->page_shift);
+ ((dma_addr_t)i << buf->page_shift);
else
bufs[total++] = buf->page_list[i].map;